Skip to content

fix compile with on_release off #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 12, 2018
Merged

fix compile with on_release off #100

merged 2 commits into from
Jan 12, 2018

Conversation

Superjomn
Copy link
Contributor

@Superjomn Superjomn commented Jan 12, 2018 •
edited
Loading

fixs: #97

@Superjomn Superjomn requested a review from jacquesqiao January 12, 2018 09:10
jacquesqiao
jacquesqiao reviewed Jan 12, 2018
View reviewed changes
Copy link
Member

@jacquesqiao jacquesqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jacquesqiao
jacquesqiao approved these changes Jan 12, 2018
View reviewed changes
Copy link
Member

@jacquesqiao jacquesqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Superjomn Superjomn merged commit 6b4db79 into PaddlePaddle:develop Jan 12, 2018
@Superjomn Superjomn deleted the bugfix/flag_release_off branch January 12, 2018 13:35
jacquesqiao pushed a commit to jacquesqiao/VisualDL that referenced this pull request Jan 12, 2018
@Superjomn
fix compile with on_release off (PaddlePaddle#100)
7780126
jacquesqiao pushed a commit to jacquesqiao/VisualDL that referenced this pull request Jan 13, 2018
@Superjomn
fix compile with on_release off (PaddlePaddle#100)
3a0bb0a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jacquesqiao jacquesqiao jacquesqiao approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Superjomn @jacquesqiao