Skip to content

Conversation

david-95
Copy link
Contributor

@david-95 david-95 commented Aug 9, 2022

fix #2232

@CLAassistant
Copy link

CLAassistant commented Aug 9, 2022

CLA assistant check
All committers have signed the CLA.

@mergify mergify bot added the T2S label Aug 9, 2022
@yt605155624
Copy link
Collaborator

please sign for CLA first, thanks

@yt605155624 yt605155624 self-requested a review August 9, 2022 10:53
@yt605155624 yt605155624 added this to the r1.1.0 milestone Aug 9, 2022
@@ -94,10 +94,12 @@ def __init__pypinyin(self):
large_pinyin.load()

load_phrases_dict({u'开户行': [[u'ka1i'], [u'hu4'], [u'hang2']]})
load_phrases_dict({u'俩个':[[u'lia3ng'],[u'ge4']]})
Copy link
Collaborator

@yt605155624 yt605155624 Aug 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这两个多音字似乎发音没什么问题,具体 badcase 的输入文本是什么?按照汉语拼音标准,"俩" == "两个","俩个" 这种用法本身就是错的

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed this line

load_phrases_dict({u'发卡行': [[u'fa4'], [u'ka3'], [u'hang2']]})
load_phrases_dict({u'放款行': [[u'fa4ng'], [u'kua3n'], [u'hang2']]})
load_phrases_dict({u'茧行': [[u'jia3n'], [u'hang2']]})
load_phrases_dict({u'行号': [[u'hang2'], [u'ha4o']]})
load_phrases_dict({u'行政': [[u'xing2'], [u'zhen4g']]})
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'zhen4g' 的标注是否正确?

>>> from pypinyin import pinyin, lazy_pinyin, Style
>>> pinyin('行政', style=Style.TONE2, heteronym=True)
[['xi2ng'], ['zhe4ng']]
>>> pinyin('行政', style=Style.TONE3, heteronym=True)
[['xing2'], ['zheng4']]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Collaborator

@yt605155624 yt605155624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yt605155624 yt605155624 merged commit 0eb598b into PaddlePaddle:develop Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

when process english text with !" , get error
3 participants