Skip to content

Conversation

@will-jl944
Copy link
Contributor

@will-jl944 will-jl944 commented Jan 9, 2025

Before submitting

  • Lint code. If there are lint issues, please format the code first.
# Install and register `pre-commit` in the project folder
pip install pre-commit && pre-commit install

# Process previous code files separately
pre-commit run --file XXXX.py
  • Add test cases into tests folder. If there are codecov issues, please add tests cases first.

PR types

Others

PR changes

Models

Description

Adapt to new flash_attention_npu api

@paddle-bot
Copy link

paddle-bot bot commented Jan 9, 2025

Thanks for your contribution!

@codecov
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.66%. Comparing base (55e7e33) to head (72847b8).
Report is 260 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9762      +/-   ##
===========================================
+ Coverage    52.41%   52.66%   +0.25%     
===========================================
  Files          729      727       -2     
  Lines       118158   115143    -3015     
===========================================
- Hits         61929    60639    -1290     
+ Misses       56229    54504    -1725     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit 331131b into PaddlePaddle:develop Jan 10, 2025
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants