[Embedding] Fix embedding random #9721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DesmonDay
force-pushed
the
fix_emb_random
branch
from
ffc4a32 to
3c1171f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9721 +/- ##
===========================================
- Coverage 53.30% 53.01% -0.29%
===========================================
Files 724 718 -6
Lines 118271 112451 -5820
===========================================
- Hits 63039 59615 -3424
+ Misses 55232 52836 -2396 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DesmonDay
force-pushed
the
fix_emb_random
branch
from
3c1171f to
b2e32ce
Compare
ZHUI
approved these changes
Dec 31, 2024
| class EmbeddingDatasetMixin: | ||
| """EmbeddingDatasetMixin.""" | ||
|
|
||
| rng = random.Random(10) # random seed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Description
Trainer所保存的random种子对于数据流不起作用，需要改成独立Random实例。