Skip to content

Conversation

@lugimzzz
Copy link
Contributor

PR types

New features

PR changes

Others

Description

支持pp

@paddle-bot
Copy link

paddle-bot bot commented Dec 25, 2024

Thanks for your contribution!

wawltor
wawltor previously approved these changes Dec 25, 2024
Copy link
Contributor

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 18.24818% with 112 lines in your changes missing coverage. Please review.

Project coverage is 52.71%. Comparing base (801682d) to head (d5bb5d0).
Report is 271 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/transformers/kto_criterion.py 12.71% 103 Missing ⚠️
paddlenlp/transformers/llama/modeling_pp.py 25.00% 3 Missing ⚠️
paddlenlp/transformers/qwen/modeling_pp.py 40.00% 3 Missing ⚠️
paddlenlp/transformers/qwen2/modeling_pp.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9695      +/-   ##
===========================================
+ Coverage    52.34%   52.71%   +0.37%     
===========================================
  Files          726      719       -7     
  Lines       117265   112504    -4761     
===========================================
- Hits         61377    59310    -2067     
+ Misses       55888    53194    -2694     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit 79695cc into PaddlePaddle:develop Dec 27, 2024
9 of 12 checks passed
@lugimzzz lugimzzz deleted the dpopp branch April 25, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants