Skip to content

Conversation

@waliwali777
Copy link
Contributor

PR types

Others

PR changes

Others

Description

add test for PIR recompute

@paddle-bot
Copy link

paddle-bot bot commented Dec 11, 2024

Thanks for your contribution!

@codecov
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.77%. Comparing base (5e1f01f) to head (67bf18d).
Report is 266 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #9621   +/-   ##
========================================
  Coverage    52.77%   52.77%           
========================================
  Files          709      709           
  Lines       111172   111172           
========================================
  Hits         58672    58672           
  Misses       52500    52500           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

echo "=========== $FUNCNAME run end ==========="
}

function llama_pir_auto_recompute_DP2_MP2_PP2(){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这样的写法会增加2个测试。建议直接在已有的测试上,加上 recompute 参数验证,只需增加一个测试。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@waliwali777 waliwali777 force-pushed the add_recompute_flag branch 2 times, most recently from f5b73df to dcea04c Compare December 16, 2024 06:29
Copy link
Contributor

@liym27 liym27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit bb97931 into PaddlePaddle:develop Dec 17, 2024
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants