Skip to content

Conversation

@zhangbo9674
Copy link
Contributor

@zhangbo9674 zhangbo9674 commented Sep 23, 2024

PR types

Bug fixes

PR changes

Others

Description

Fix ckpt convert bug for sharding v2

@CLAassistant
Copy link

CLAassistant commented Sep 23, 2024

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 53.06%. Comparing base (bc55104) to head (1e12da5).
Report is 9 commits behind head on develop.

Current head 1e12da5 differs from pull request most recent head 507298a

Please upload reports for the commit 507298a to get more accurate results.

Files with missing lines Patch % Lines
paddlenlp/trainer/utils/ckpt_converter.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9179      +/-   ##
===========================================
- Coverage    53.07%   53.06%   -0.02%     
===========================================
  Files          656      656              
  Lines       106095   106147      +52     
===========================================
+ Hits         56309    56324      +15     
- Misses       49786    49823      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZHUI ZHUI merged commit 1b8f37f into PaddlePaddle:develop Sep 25, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants