Skip to content

Conversation

@Wennie396
Copy link
Contributor

@Wennie396 Wennie396 commented Sep 19, 2024

PR types

Others

PR changes

Others

Description

给自动并行增加一个AutoTrainingArguments类,后续自动并行的相关优化开关可以放到这里面而不用每个模型都重新写一次这些优化开关的arguments,只需要写自己相关的args即可

@CLAassistant
Copy link

CLAassistant commented Sep 19, 2024

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.02%. Comparing base (f80a051) to head (28e21fe).
Report is 256 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9155      +/-   ##
===========================================
- Coverage    53.02%   53.02%   -0.01%     
===========================================
  Files          656      657       +1     
  Lines       106153   106311     +158     
===========================================
+ Hits         56288    56367      +79     
- Misses       49865    49944      +79     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wennie396 Wennie396 closed this Sep 20, 2024
@Wennie396 Wennie396 reopened this Sep 20, 2024
@Wennie396 Wennie396 marked this pull request as draft September 20, 2024 02:13
@Wennie396 Wennie396 marked this pull request as ready for review September 20, 2024 02:14
@Wennie396 Wennie396 marked this pull request as draft September 20, 2024 02:51
@Wennie396 Wennie396 marked this pull request as ready for review September 20, 2024 02:51
@paddle-bot
Copy link

paddle-bot bot commented Sep 26, 2024

Thanks for your contribution!

class AutoTrainingArguments(TrainingArguments):
"""
自动并行相关参数配置
"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

主库里面的代码,建议写英文注释

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done



@dataclass
@add_start_docstrings(TrainingArguments.__doc__)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@add_start_docstrings(TrainingArguments.__doc__)
@add_start_docstrings(AutoTrainingArguments.__doc__)

可以这么换一下,看看是不是正常能够提示参数

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZHUI ZHUI merged commit c2fcc3e into PaddlePaddle:develop Sep 30, 2024
9 of 12 checks passed
@Wennie396 Wennie396 deleted the auto_args branch November 19, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants