Skip to content

Conversation

@deepllz
Copy link
Collaborator

@deepllz deepllz commented Aug 14, 2024

PR types

Others

PR changes

Others

Description

Others

@paddle-bot
Copy link

paddle-bot bot commented Aug 14, 2024

Thanks for your contribution!

param+="global_batch_size=32 "
param+="model_item=qwen-qwen-14b_seqlen4096_pretrain "
param+="max_steps=100 "
param+="logging_steps=5"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

此处需要后面加上空格,param+="logging_steps=5 "

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

param+="global_batch_size=32 "
param+="model_item=qwen-qwen-7b_seqlen4096_pretrain "
param+="max_steps=100 "
param+="logging_steps=5"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

此处需要后面加上空格,param+="logging_steps=5 "

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@codecov
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.12%. Comparing base (0cc8554) to head (a34ea60).
Report is 231 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8928      +/-   ##
===========================================
+ Coverage    55.05%   55.12%   +0.07%     
===========================================
  Files          635      635              
  Lines        99410    99420      +10     
===========================================
+ Hits         54729    54805      +76     
+ Misses       44681    44615      -66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

"warmup_ratio": 0.01,
"max_grad_norm": 1.0,
"logging_steps": 1,
"logging_steps": 5,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个max_steps是100,这里logging_steps设置成 5,打印的ips不够用

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

"warmup_ratio": 0.01,
"max_grad_norm": 1.0,
"logging_steps": 1,
"logging_steps": 5,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个max_steps是100,这里logging_steps设置成 5,打印的ips不够用

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

param+="global_batch_size=32 "
param+="model_item=qwen-qwen-7b_seqlen4096_pretrain "
param+="max_steps=100 "
param+="logging_steps=5 "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个max_steps是100,这里logging_steps设置成 5,打印的ips不够用

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

param+="global_batch_size=32 "
param+="model_item=qwen-qwen-14b_seqlen4096_pretrain "
param+="max_steps=100 "
param+="logging_steps=5 "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个max_steps是100,这里logging_steps设置成 5,打印的ips不够用

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZHUI ZHUI merged commit 75c7636 into PaddlePaddle:develop Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants