Skip to content

Conversation

@xiaoguoguo626807
Copy link
Contributor

@xiaoguoguo626807 xiaoguoguo626807 commented Aug 8, 2024

PR types

Bug fixes

PR changes

Others

Description

pcard-67164
pir 下while op 要求输入和输出都是类型相同的value, 此处model_kwargs 作为while 的输入是一个dict ,dict 中包含了为none 的数据,while 无法支持,因此需要根据其是否为none 判断是否要加入dict中。 当这些参数为none时,sample 函数中不会使用到,因此不会对程序正确性产生影响
截屏2024-08-08 15 28 34

@paddle-bot
Copy link

paddle-bot bot commented Aug 8, 2024

Thanks for your contribution!

@codecov
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 55.36%. Comparing base (5c57015) to head (2423220).
Report is 245 commits behind head on develop.

Files with missing lines Patch % Lines
...enlp/experimental/transformers/generation_utils.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8898      +/-   ##
===========================================
- Coverage    55.36%   55.36%   -0.01%     
===========================================
  Files          631      631              
  Lines        98888    98890       +2     
===========================================
- Hits         54750    54747       -3     
- Misses       44138    44143       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vivienfanghuagood vivienfanghuagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit 57a42f8 into PaddlePaddle:develop Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants