Skip to content

Conversation

@DesmonDay
Copy link
Contributor

PR types

Bug fixes

PR changes

Others

Description

Fix tie_word_embeddings config.

@paddle-bot
Copy link

paddle-bot bot commented Jul 23, 2024

Thanks for your contribution!

@DesmonDay DesmonDay force-pushed the fix_uc_tied_weight branch from 500a1c0 to a37df5b Compare July 23, 2024 09:43
@codecov
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 55.50%. Comparing base (7c18d9d) to head (635be9e).
Report is 247 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/trainer/plugins/unified_checkpoint.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8795      +/-   ##
===========================================
+ Coverage    55.03%   55.50%   +0.47%     
===========================================
  Files          627      631       +4     
  Lines        98921    98544     -377     
===========================================
+ Hits         54440    54701     +261     
+ Misses       44481    43843     -638     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DesmonDay DesmonDay force-pushed the fix_uc_tied_weight branch from a37df5b to 635be9e Compare July 30, 2024 11:22
Copy link
Contributor

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZHUI ZHUI merged commit 77480a0 into PaddlePaddle:develop Aug 1, 2024
DrownFish19 pushed a commit to DrownFish19/PaddleNLP that referenced this pull request Aug 2, 2024
[UC] Fix tie_word_embeddings (PaddlePaddle#8795)

fix

fix

fix

fix

fix
DrownFish19 pushed a commit to DrownFish19/PaddleNLP that referenced this pull request Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants