fix incorrect token counting in llm/predictor.py
#8769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8769 +/- ##
===========================================
+ Coverage 55.43% 55.51% +0.07%
===========================================
Files 626 626
Lines 98070 98070
===========================================
+ Hits 54366 54440 +74
+ Misses 43704 43630 -74 ☔ View full report in Codecov by Sentry. |
vivienfanghuagood
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Description
The
benchmark()function is currently counting the number of generated characters instead of the generated tokens, which is incorrect for speed test. This PR modified thepredict()interface and let it can optionally return the generated tokens before postprocessing, so that it can count the number of generated tokens in thebenchmark()function.