- 
                Notifications
    You must be signed in to change notification settings 
- Fork 3.1k
[Trainer] ignore_save_lr_and_optim #7978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Thanks for your contribution! | 
| Codecov ReportAttention:  
 
 Additional details and impacted files@@           Coverage Diff            @@
##           develop    #7978   +/-   ##
========================================
  Coverage    56.56%   56.56%           
========================================
  Files          589      589           
  Lines        89954    89956    +2     
========================================
+ Hits         50885    50887    +2     
  Misses       39069    39069           ☔ View full report in Codecov by Sentry. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| self.optimizer.state_dict(), | ||
| os.path.join(output_dir, optimizer_name), | ||
| ) | ||
| if self.args.use_hybrid_parallel: | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ZHUI 帮忙确认下这个改动是否对自动并行生肖
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不影响
| self.optimizer.state_dict(), | ||
| os.path.join(output_dir, optimizer_name), | ||
| ) | ||
| if self.args.use_hybrid_parallel: | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不影响
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR types
New features
PR changes
APIs
Description
新增忽略保存lr和optim的可选项,默认值为False,跟以前一样,只有想要使用的时候指定开启。