Skip to content

Conversation

@greycooker
Copy link
Contributor

PR types

Bug Fix

PR changes

fix a bug of trainer/argparser.py

Description

modify the Trainer class's parse_json_file_and_cmd_lines function in order to correctly handle list-format parameters in a JSON file, which are currently can not parse correctly.

@paddle-bot
Copy link

paddle-bot bot commented Jan 18, 2024

Thanks for your contribution!

@codecov
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (48c1313) 56.91% compared to head (d02af23) 56.90%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7860      +/-   ##
===========================================
- Coverage    56.91%   56.90%   -0.01%     
===========================================
  Files          587      587              
  Lines        88740    88742       +2     
===========================================
- Hits         50502    50500       -2     
- Misses       38238    38242       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gongel gongel merged commit 283c535 into PaddlePaddle:develop Jan 22, 2024
JunnYu pushed a commit that referenced this pull request Jan 22, 2024
@greycooker greycooker deleted the fix_trainer_argparser branch August 29, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants