Skip to content

Conversation

@linjieccc
Copy link
Contributor

@linjieccc linjieccc commented Jan 5, 2023

PR types

Bug fixes

PR changes

APIs

Description

@paddle-bot
Copy link

paddle-bot bot commented Jan 5, 2023

Thanks for your contribution!

@linjieccc linjieccc requested review from carryyu and zjjlivein January 5, 2023 12:31
@linjieccc linjieccc self-assigned this Jan 5, 2023
@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Merging #4359 (2b612e0) into develop (ee14e04) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #4359      +/-   ##
===========================================
- Coverage    38.67%   38.67%   -0.01%     
===========================================
  Files          421      421              
  Lines        59599    59600       +1     
===========================================
- Hits         23052    23051       -1     
- Misses       36547    36549       +2     
Impacted Files Coverage Δ
paddlenlp/taskflow/task.py 36.32% <0.00%> (-0.15%) ⬇️
paddlenlp/utils/downloader.py 54.09% <0.00%> (-0.41%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@zjjlivein zjjlivein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjjlivein zjjlivein merged commit 943a0ff into PaddlePaddle:develop Jan 5, 2023
@linjieccc linjieccc deleted the fix-taskflow-ci branch January 5, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants