Skip to content

Conversation

@w5688414
Copy link
Contributor

PR types

  • New features

PR changes

  • Models&APIs

Description

  • Add English semantic search of pipelines with rocketqav2

@w5688414 w5688414 requested a review from wawltor November 10, 2022 07:48
@w5688414 w5688414 self-assigned this Nov 10, 2022
@w5688414 w5688414 added pipelines enhancement New feature or request labels Nov 10, 2022
"At least one of query_ernie and title_ernie should not be None"

# Compatible to rocketv2 initialization
if (reinitialize):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这块的语法有点奇怪,不需要加括号吧

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改

wawltor
wawltor previously approved these changes Nov 16, 2022
Copy link
Contributor

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@w5688414 w5688414 merged commit cd29ed8 into PaddlePaddle:develop Nov 16, 2022
@w5688414 w5688414 deleted the pip40 branch November 1, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request pipelines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants