Add embedding inputs to T5 model #3668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrostML
reviewed
Nov 8, 2022
| test_resize_position_embeddings = False | ||
| test_mismatched_shapes = True | ||
| test_missing_keys = True | ||
| use_test_inputs_embeds = False |
Contributor
There was a problem hiding this comment.
这里的 use_test_inputs_embeds 好像在下面的单测中没有用到了？
sijunhe
reviewed
Nov 9, 2022
| inputs["decoder_inputs_embeds"] = wte(decoder_input_ids) | ||
|
|
||
| with paddle.no_grad(): | ||
| model(**inputs)[0] |
Contributor
There was a problem hiding this comment.
这里的测试逻辑是要求他不报错吗？能否加上一个直接用input_ids跑和input_embeds跑的assertEquals?
…ut from input_embeds to test_inputs_embeds
sijunhe
reviewed
Nov 10, 2022
| with paddle.no_grad(): | ||
| embeds_output = model(**inputs) | ||
|
|
||
| assert paddle.allclose(ids_output, embeds_output, 1e-4, 1e-4) |
Contributor
There was a problem hiding this comment.
- 这里不能直接用python的assert. 需要用unittest这个class的assert
- 代码风格上，最好把1e-4的的key加上
self.assertTrue(paddle.allclose(ids_output, embeds_output, atol=1e-4))
sijunhe
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Models
Description
test_inputs_embedstotest_modeling_common.py