Recv OP: use BlockDesc* instread of ProgramDesc proto as Attribute #7621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helinwang
changed the title
typhoonzero
reviewed
Jan 18, 2018
| outputs={}, | ||
| attrs={ | ||
| "OptimizeProgram": optimize_sub_program.desc, | ||
| "OptimizeBlock": optimize_sub_program.global_block(), |
There was a problem hiding this comment.
We can merge optimize_sub_program to the pserver_program as the second block (block_id 1), then we don't need to create variables in both two of the programs.
typhoonzero
previously approved these changes
Jan 18, 2018
|
@typhoonzero sure! I will add a followup PR. Created an issue about it: #7700 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #7343