Skip to content

Add get set lod for infershape #7606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add get set lod for infershape #7606

wants to merge 2 commits into from

Conversation

@jacquesqiao
Copy link
Member

@jacquesqiao jacquesqiao commented Jan 17, 2018 •
edited
Loading

fix: #7630

@jacquesqiao jacquesqiao requested a review from pkuyym January 17, 2018 11:35
wangkuiyi
wangkuiyi requested changes Jan 17, 2018
View reviewed changes
Copy link
Collaborator

@wangkuiyi wangkuiyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a description or an issue explaining why we need to add Get/SetLOD, so could we have a record of the reasoning behind the code change.

@jacquesqiao
Copy link
Member Author

@wangkuiyi issue updated, please review, thanks!

@jacquesqiao jacquesqiao closed this Mar 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wangkuiyi wangkuiyi wangkuiyi requested changes

@pkuyym pkuyym Awaiting requested review from pkuyym

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

add Get/Set LoD in InfershapeContext

2 participants

@jacquesqiao @wangkuiyi