Skip to content

fix mkldnn concat dimension issue for rnn #7592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2018
Merged

fix mkldnn concat dimension issue for rnn #7592

merged 1 commit into from
Jan 17, 2018

Conversation

tensor-tang
Copy link
Contributor

fix crash issue on ds2 with mkldnn.

Thread [139674823313216] Forwarding concat_2,
*** Aborted at 1516169708 (unix time) try "date -d @1516169708" if you are using GNU date ***
PC: @ 0x0 (unknown)
Segmentation fault (core dumped)

After debuging, we find it's caused by concat dimension.

@tensor-tang tensor-tang requested a review from luotao1 January 17, 2018 07:00
luotao1
luotao1 approved these changes Jan 17, 2018
View reviewed changes
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 939e1b1 into PaddlePaddle:develop Jan 17, 2018
@tensor-tang tensor-tang deleted the fixds2 branch January 17, 2018 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@luotao1 luotao1 luotao1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tensor-tang @luotao1