Skip to content

enhance/add lod check #7439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 17, 2018
Merged

enhance/add lod check #7439

merged 3 commits into from
Jan 17, 2018

Conversation

Superjomn
Copy link
Contributor

@Superjomn Superjomn commented Jan 11, 2018 •
edited
Loading

  • add format check for both relative and absolute LoD

@Superjomn Superjomn requested a review from qingqing01 January 15, 2018 03:01
qingqing01
qingqing01 approved these changes Jan 15, 2018
View reviewed changes
Copy link
Contributor

@qingqing01 qingqing01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Superjomn Superjomn merged commit ac73900 into PaddlePaddle:develop Jan 17, 2018
@Superjomn Superjomn deleted the enhance/lod_check_valid branch January 17, 2018 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qingqing01 qingqing01 qingqing01 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Superjomn @qingqing01