Skip to content

Conversation

@DrRyanHuang
Copy link
Contributor

@DrRyanHuang DrRyanHuang commented Mar 3, 2025

PR Category

Execute Infrastructure

PR Types

Bug fixes

Description

class BreakGraphError(SotErrorBase):
    def __init__(self, reason: BreakGraphReasonBase | str = None):
        super().__init__()   # <------ 

        if isinstance(reason, str):
            # if reason is a string, then create a UnspecifiedBreakReason object
            reason = UnspecifiedBreakReason(reason)
        self.reason = reason
        BreakGraphReasonInfo.collect_break_graph_reason(reason)

Due to the inheritance relationship BreakGraphError <- SotErrorBase <- Exception, not passing any arguments to super().__init__() will result in the raised exception containing no information.😱😱😱

PCard-66972

Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@DrRyanHuang DrRyanHuang requested a review from SigureMo March 4, 2025 11:27
@SigureMo SigureMo merged commit c926df5 into PaddlePaddle:develop Mar 4, 2025
34 checks passed
@DrRyanHuang DrRyanHuang deleted the fix_lost_info branch March 4, 2025 11:58
Enigmatisms pushed a commit to Enigmatisms/Paddle that referenced this pull request Mar 6, 2025
YqGe585 pushed a commit to YqGe585/Paddle that referenced this pull request May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants