[SOT] Add support for numpy ufunc with numpy number #71295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
changed the title
test/sot/test_numpy.py
Outdated
Comment on lines
60
to
61
| return a, b, c, d, e, f, g, h, i, j, h | ||
|
|
There was a problem hiding this comment.
The return tuple includes the variable 'h' twice, which appears to be an unintentional duplication. Please verify if both occurrences are intended or if one should be replaced with a different variable.
Suggested change
| return a, b, c, d, e, f, g, h, i, j, h | |
| return a, b, c, d, e, f, g, h, i, j, i |
There was a problem hiding this comment.
可以，还有点用，虽然 suggest 的 code 不太对
DrRyanHuang
reviewed
Feb 26, 2025
Comment on lines
1360
to
1361
| if unary_fn in [bool]: | ||
| continue |
There was a problem hiding this comment.
Consider using if unary_fn is bool: instead of if unary_fn in [bool]: for direct type comparison, improving readability and avoiding the unnecessary use of a list.
SigureMo
changed the title
zrr1999
approved these changes
Feb 27, 2025
SigureMo
deleted the
sot/add-support-for-numpy-ufunc-with-numpy-number
branch
Enigmatisms
pushed a commit
to Enigmatisms/Paddle
that referenced
this pull request
Mar 6, 2025
YqGe585
pushed a commit
to YqGe585/Paddle
that referenced
this pull request
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Execute Infrastructure
PR Types
Performance
Description
对 NumPy number 及其操作进行支持，这包括了：
ufunc(const)产生 NumPy numberint/float/np.number.item转回 constPCard-66972