Skip to content

Conversation

@liufengwei0103
Copy link
Contributor

@liufengwei0103 liufengwei0103 commented Feb 26, 2025

PR Category

User Experience

PR Types

Improvements

Description

  1. support kwargs in forward pre hook
  2. shard kwargs in pp auto parallel

Pcard-67164

@paddle-bot
Copy link

paddle-bot bot commented Feb 26, 2025

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@liufengwei0103 liufengwei0103 marked this pull request as draft February 26, 2025 03:40
@liufengwei0103 liufengwei0103 changed the title Support kwargs in pre hook Support kwargs in forward pre hook Feb 26, 2025
@liufengwei0103 liufengwei0103 marked this pull request as ready for review February 26, 2025 07:27
@liufengwei0103 liufengwei0103 marked this pull request as draft February 26, 2025 07:35
@liufengwei0103 liufengwei0103 marked this pull request as ready for review February 26, 2025 07:56
Copy link
Contributor

@From00 From00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾 for new arg type annotations

Copy link
Contributor

@jeff41404 jeff41404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@From00 From00 merged commit 3fc4ca3 into PaddlePaddle:develop Feb 27, 2025
32 checks passed
Enigmatisms pushed a commit to Enigmatisms/Paddle that referenced this pull request Mar 6, 2025
* support kwargs in forward pre hook

* fix args passing

* move test case to test_imperative_hook_for_layer.py

* add test after remove hook

* let auto parallel pp llama test case use kwargs after global layer

* rename var and delete useless code

* format code

* fix bug

* fix bug

* remove kwargs flag when removing hook

* fix hook id
YqGe585 pushed a commit to YqGe585/Paddle that referenced this pull request May 7, 2025
* support kwargs in forward pre hook

* fix args passing

* move test case to test_imperative_hook_for_layer.py

* add test after remove hook

* let auto parallel pp llama test case use kwargs after global layer

* rename var and delete useless code

* format code

* fix bug

* fix bug

* remove kwargs flag when removing hook

* fix hook id
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants