【custom】split Custom depend header #71036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0ea393b.
|
你的PR提交成功，感谢你对开源项目的贡献! |
xiaoguoguo626807
force-pushed
the
custom_depend
branch
from
9cd34ef to
a751e83
Compare
zhangbo9674
reviewed
Feb 8, 2025
|
|
||
| constexpr int kEmptyVarIndex = 0; | ||
|
|
||
| struct EventInter { |
There was a problem hiding this comment.
new_executor_def 中原本定义了两类数据结构：一类是 Instruction 的成员，一类是 Interpreter 用到的成员，这个 new_executor_base_def.h 建议直接迁移到 instruction 目录下，改成 instruction_def.h 吧
xiaoguoguo626807
changed the title
zyfncg
approved these changes
Feb 10, 2025
| @@ -0,0 +1,52 @@ | |||
| // Copyright (c) 2021 PaddlePaddle Authors. All Rights Reserved. | |||
| @@ -0,0 +1,45 @@ | |||
| // Copyright (c) 2023 PaddlePaddle Authors. All Rights Reserved. | |||
There was a problem hiding this comment.
这些文件是移动，不是新建，所以没改创建日期
YqGe585
pushed a commit
to YqGe585/Paddle
that referenced
this pull request
May 7, 2025
* [custom] dependency for custom_engine * add extention * add .cc * add declear * [GCU] Open more information for instruction * revert fix * Revert "add extention" This reverts commit 0ea393b. * fix conflict * recover pd_op_to_kernel_pass * modify setup.py * fix build * fix build * ercover deviceevent * modify header name * modify xpu build * delete // * rename new_executor_base_defs.h * rename new_executor_base_defs.h --------- Co-authored-by: EnflameGCU <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Execute Infrastructure
PR Types
Improvements
Description
pcard-67164
拆解部分头文件，避免暴露pir 无关的头文件