-
Notifications
You must be signed in to change notification settings - Fork 5.9k
【custom】add train pass flag #70909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【custom】add train pass flag #70909
Conversation
| } | ||
| #if defined(PADDLE_WITH_CUSTOM_DEVICE) | ||
| if (!FLAGS_enable_custom_engine.empty()) { | ||
| std::string custom_engine_translate_pass = FLAGS_enable_custom_engine; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不需要吧?
| const std::set<std::string> &no_need_buffer_names) { | ||
| #if defined(PADDLE_WITH_CUSTOM_DEVICE) | ||
| if (!FLAGS_enable_custom_engine.empty()) { | ||
| std::string custom_engine_translate_pass = FLAGS_enable_custom_engine; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不需要吧?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copy 一份处理更安全些
| */ | ||
| PHI_DEFINE_EXPORTED_string(enable_custom_engine, | ||
| "", | ||
| "Set CustomDevice subgraph engine translate pass"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
看代码,pass 中间要使用逗号隔离,这里建议给一个使用示例,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
下个PR 修复
zhangbo9674
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overrall
PR Category
Execute Infrastructure
PR Types
Improvements
Description
pcard-67164
添加训练流程中启动子图匹配pass 的flag