Skip to content

Conversation

@xiaoguoguo626807
Copy link
Contributor

@xiaoguoguo626807 xiaoguoguo626807 commented Jan 21, 2025

PR Category

Execute Infrastructure

PR Types

Improvements

Description

pcard-67164

添加训练流程中启动子图匹配pass 的flag

}
#if defined(PADDLE_WITH_CUSTOM_DEVICE)
if (!FLAGS_enable_custom_engine.empty()) {
std::string custom_engine_translate_pass = FLAGS_enable_custom_engine;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不需要吧?

const std::set<std::string> &no_need_buffer_names) {
#if defined(PADDLE_WITH_CUSTOM_DEVICE)
if (!FLAGS_enable_custom_engine.empty()) {
std::string custom_engine_translate_pass = FLAGS_enable_custom_engine;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不需要吧?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy 一份处理更安全些

*/
PHI_DEFINE_EXPORTED_string(enable_custom_engine,
"",
"Set CustomDevice subgraph engine translate pass");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看代码,pass 中间要使用逗号隔离,这里建议给一个使用示例,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

下个PR 修复

Copy link
Contributor

@zhangbo9674 zhangbo9674 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overrall

@xiaoguoguo626807 xiaoguoguo626807 merged commit 8c590fa into PaddlePaddle:develop Jan 23, 2025
31 checks passed
@xiaoguoguo626807 xiaoguoguo626807 deleted the train_pass branch January 23, 2025 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants