Skip to content

Conversation

@fangfangssj
Copy link
Contributor

PR Category

User Experience

PR Types

Bug fixes

Description

为sqrt增加了复数类型的支持,test_activation_op.py原本就包含许多的报错,新建文件后测试,sqrt的测试均通过
53a1259426d02e1fed0514d976b4bff1

@paddle-bot paddle-bot bot added the contributor External developers label Jan 6, 2025
@luotao1 luotao1 added the HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务 label Jan 7, 2025
Copy link
Contributor

@HydrogenSulfate HydrogenSulfate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CPU的SqrtGradFunctor好像没覆盖到?可以确认下。
image

@fangfangssj
Copy link
Contributor Author

CPU的SqrtGradFunctor好像没覆盖到?可以确认下。 image

ci测试好像关掉了test_activation_op这个单测,这个测试里面有很多报错(拉取paddle仓库的代码后直接运行测试,有三个段错误和几个失败的测试)

@HydrogenSulfate
Copy link
Contributor

CPU的SqrtGradFunctor好像没覆盖到?可以确认下。 image

ci测试好像关掉了test_activation_op这个单测,这个测试里面有很多报错(拉取paddle仓库的代码后直接运行测试,有三个段错误和几个失败的测试)

好的

Copy link
Contributor

@HydrogenSulfate HydrogenSulfate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HydrogenSulfate HydrogenSulfate merged commit 961393d into PaddlePaddle:develop Jan 8, 2025
30 of 31 checks passed
@fangfangssj fangfangssj deleted the sqrt branch March 12, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants