[CINN] fix slice op sym infer with input(with data) and symbol starts or ends #70282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
Description 中后面带上 Pcard-67164 的标识 |
gongshaotian
approved these changes
Dec 17, 2024
已添加 |
| const auto &out_shape = | ||
| in_shapeordata.data().has_value() && starts_ends_all_int | ||
| ? GetDataDimExprs() | ||
| : GetShapeDimExprs(); |
There was a problem hiding this comment.
这两个函数起名有点模糊，之后可以考虑系统性优化下
There was a problem hiding this comment.
是的，这俩是历史遗留问题了，slice后面估计要大改
Hongqing-work
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
Others
Description
Pcard-67164
或者 ends - starts (会超过 idim)可以化简成一个整数时（shape 为 0D/1D 且是整数）取 abs ，在 data 区产生新符号