Skip to content

Conversation

@blacksheep-Aristotle
Copy link
Contributor

@blacksheep-Aristotle blacksheep-Aristotle commented Dec 12, 2024

PR Category

Auto Parallel

PR Types

New features

Description

自动并行中层api支持对共享参数做tp/pp & 添加相应单测
Pcard-67164

@paddle-bot
Copy link

paddle-bot bot commented Dec 12, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@FeixLiu FeixLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

那几个dict,share_param_listlayer_param_placementsparam_placements,求加点注释。。。至少写明数据的结构、mapping的含义以及作用。这个和那个mp shard axis的修复pr放一起吧。

shard_bias,
)
return model
if param_placements is not None and param_placements:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个and前后的区别是啥

@jeff41404 jeff41404 merged commit dc2b7c9 into PaddlePaddle:develop Dec 13, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants