【Infer Symbolic Shape No.232】Add infer_symbol_shape for StridedSlice #69911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
gongshaotian
reviewed
Dec 3, 2024
| ExprVec ends = slice_utils::GetExprVecFromData(ends_shape_data); | ||
| ExprVec strides = slice_utils::GetExprVecFromData(strides_shape_data); | ||
|
|
||
| std::vector<int64_t> axes_vec = details::GetVectorAttr(op, "axes"); |
Hongqing-work
approved these changes
Dec 4, 2024
Contributor
|
规范下 Description |
Contributor
|
TestStridedSliceAPI 和 TestStridedSliceTensorArray 的单测问题交由 @kevincheng2 修复 |
zyfncg
approved these changes
Dec 4, 2024
| return slice_dims; | ||
| } | ||
|
|
||
| inline ShapeOrData StridedSliceRawInferSymbolicShape( |
Contributor
There was a problem hiding this comment.
StridedSliceRawInferSymbolicShape这个函数为什么放到infer_sym_slice_utils.h文件中？
Contributor
There was a problem hiding this comment.
SliceRawInferSymbolicShape 也放在utils.h里了，放一起容易维护
gongshaotian
reviewed
Dec 4, 2024
| symbol::TensorShapeOrDataDimExprs(out_dims)}; | ||
| }; | ||
|
|
||
| // When `pd.slice` is operating on a tensor which is produced by a `pd.shape` |
gongshaotian
reviewed
Dec 4, 2024
Comment on lines
+3506
to
+3507
| std::vector<int64_t>{}, | ||
| std::vector<int64_t>{}, |
Contributor
There was a problem hiding this comment.
确认一下，infer_flags_raw 和 decrease_axis 默认都是空有问题吗
Contributor
Author
There was a problem hiding this comment.
这里是因为
stride_slice并未注册这两个参数，导致无法通过GetVectorAttr得到的StridedSliceRawInferSymbolicShape复用了slice的GetDecreasedDims所以对decrease_axis这里构造了空向量，而infer_flags这个参数是一个无效参数，在slice和stride_slice均没有用到
Contributor
|
原PR：#69290 |
Contributor
|
APPROVAL 流水线发现了一些报错信息规范的问题，可以与注释一起提pr修改，连带检查下slice的几个工具函数里是不是报错信息也不规范 |
gongshaotian
approved these changes
Dec 4, 2024
This was referenced Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
New features
Description
TestStridedSliceAPI和TestStridedSliceTensorArray无法通过starts、ends和strides为Inputs的单测因无法在运行前得到，所以禁用