[CodeStyle][Typos][A-45] Fix typo (AVALIABLE)
#69652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
学一下分支管理，别从上一个 PR 的分支继续提 PR |
那这次的提交还要改吗 |
这次可以不改分支，但你得解决冲突啊 |
SigureMo
changed the title
SigureMo
changed the title
AVALIABLE)
SigureMo
changed the title
AVALIABLE)AVALIABLE)
SigureMo
requested changes
Nov 23, 2024
_typos.toml
Outdated
kanze1
force-pushed
the
fix_typo_available
branch
from
c98fc33 to
9434d7a
Compare
SigureMo
requested changes
Nov 23, 2024
cmake/cuda.cmake
Outdated
| @@ -287,7 +287,7 @@ elseif(${CMAKE_CUDA_COMPILER_VERSION} LESS 13.0) # CUDA 12.0+ | |||
| endif() | |||
|
|
|||
| if(NOT ${CMAKE_CUDA_COMPILER_VERSION} LESS 10.0) | |||
| add_definitions("-DTRT_PLUGIN_FP16_AVALIABLE") | |||
| add_definitions("-DTRT_PLUGIN_FP16_available") | |||
There was a problem hiding this comment.
他原本就是全大写，我应该是只修复原本的那一个错误，然后关于大写的就不动，那之前合并的那次pr应该就可以了对吗？我修改描述说明这个宏定义的大写不需要修改是不是这个意思？
There was a problem hiding this comment.
AVALIABLE -> AVAILABLE 怎么能是不动呢？这里是拼写错误又不是大小写错误
kanze1
force-pushed
the
fix_typo_available
branch
from
9434d7a to
048ea14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Bug fixes
Description
修复代码中的拼写错误并更新 _typos.toml：
修复 round_robin.h 中的拼写错误：
将注释中的 "AVALIABLE" 改为 "available"
更新 _typos.toml：
删除了已修复的 "AVALIABLE= 'AVALIABLE'" 条目