Skip to content

Conversation

@co63oc
Copy link
Contributor

@co63oc co63oc commented Nov 18, 2024

PR Category

Operator Mechanism

PR Types

Others

Description

移除 IsValidLoDTensor

@paddle-bot
Copy link

paddle-bot bot commented Nov 18, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Nov 18, 2024
@co63oc co63oc changed the title CI测试不review[fluid_ops] IsValidLoDTensor [Lod][fluid_ops] IsValidLoDTensor Nov 18, 2024
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的逻辑有非LOD的成分。不能全部删除。以后这种类似的也是一样。

Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@co63oc
Copy link
Contributor Author

co63oc commented Nov 20, 2024

@luotao1 CI已完成

@luotao1 luotao1 merged commit 4969543 into PaddlePaddle:develop Nov 20, 2024
27 of 28 checks passed
@co63oc co63oc deleted the fix88 branch November 28, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants