【CINN】Enrich ability of index expr #68986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zyfncg
reviewed
Oct 28, 2024
Comment on lines
+191
to
+211
| // TODO(liuruyan): canby simplify into IndexExpr multiply. | ||
| ir::IndexExpr MulAndNormalize(const ir::IndexExpr &lhs, | ||
| const ir::IndexExpr &rhs); | ||
|
|
||
| int32_t CalculateExprComplexity(const Expr &expr, int count = 0); | ||
|
|
||
| // True means don't change sequence | ||
| bool IsCorrectPriority(const Expr &lhs, const Expr &rhs); | ||
|
|
||
| bool IsSumPartialBySymbol(const ir::IndexExpr &expr, | ||
| const ir::IndexExpr &symbol); | ||
|
|
||
| // If true is returned, the operation will be attempted on each subpart in | ||
| // outter `simplify` function. Note: this func dont deal the corner case, e.g. | ||
| // `IsDivisiblieBySymbol(f % S0 - f, S0)` is `false`. please use | ||
| // `ProveDivisible` for exact result. | ||
| bool IsDivisiblieBySymbol(const ir::IndexExpr &expr, | ||
| const ir::IndexExpr &symbol, | ||
| const ir::IrNodeTy &ty); | ||
|
|
||
| bool ProveDivisible(const ir::IndexExpr &lhs, const ir::IndexExpr &rhs); |
There was a problem hiding this comment.
这几个接口再补充一些注释说明，能给出示例的尽量用例子说明一下
| return ir::Min::Make(a, b); | ||
| } | ||
|
|
||
| int32_t CalculateExprComplexity(const Expr &expr, int count) { |
There was a problem hiding this comment.
这里用Complexity是否准确？看着只是做节点数量的统计
| } | ||
| } | ||
|
|
||
| bool IsCorrectPriority(const Expr &lhs, const Expr &rhs) { |
There was a problem hiding this comment.
这个看上去是做两个Expr的比较，CorrectPriority在语义上看不太出来返回true是左边Priority高还是右边Priority高
zyfncg
approved these changes
Oct 28, 2024
fxfxfxfxfxfxfxfx
pushed a commit
to fxfxfxfxfxfxfxfx/Paddle
that referenced
this pull request
Oct 29, 2024
* enrich IndexEpxr * fix * fix bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
New features
Description
ProveDivisiblewithoutAutoSimplifyandanalyzer.IndexExpr, constant must be at therhsoperand inAddandMul. e.g.AddandMulnow . e.g.Addfor constants. e.g.IsSumPartialBySymbolfunc forAddandIsDivisiblieBySymbolfunc forDiv, It can judge whether the expression can be simplified. if return true, then will applySimplifySymbolicAddandSimplifySymbolicDivideto simplify.Normalizefunc forIndexExpr, Its function is to explicitly reconstruct anIndexExprand simplify it at the same time. It usually use when an unsimplifiedExpris converted to anIndexExprusingas_index(), e.g.Pcard-67164