[XPU] reuse logits and softmax to avoid redundant memory allocation #68906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
这个PR修改了 |
lj970926
approved these changes
Oct 24, 2024
| logits_2d.Resize({N, D}); | ||
| softmax_2d.Resize({N, D}); | ||
| logits_2d.ShareDataWith(*logits).Resize({N, D}); | ||
| softmax_2d.ShareDataWith(*softmax).Resize({N, D}); |
There was a problem hiding this comment.
下面CSoftmaxWithCrossEntropyFunctor（line 389~line 395）那里是不是也可以一起改下？
runzhech
force-pushed
the
softmax_crossentropy
branch
from
b59033a to
910294f
Compare
HarperCy
reviewed
Oct 24, 2024
| logits_2d.Resize({N, D}); | ||
| softmax_2d.Resize({N, D}); | ||
| logits_2d.ShareDataWith(*logits).Resize({N, D}); | ||
| softmax_2d.ShareDataWith(*softmax).Resize({N, D}); |
There was a problem hiding this comment.
sharedatawith我记得paddle同学说过，是访问同一块地址，会有潜在的风险。之前paddle cast，在数据类型相同时，就是用了sharedatawith，模型训练有时就会有奇怪的现象
There was a problem hiding this comment.
这个算子比较特殊，sharedatawith的是两个临时tensor。其中logits_2d不会被修改，softmax_2d在修改后原本就会被写回原地址，逻辑上跟之前一样，所以不会有问题。
houj04
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Custom Device
PR Types
Improvements
Description
Using "ShareDataWith" instead of "TensorCopy" for logits and softmax to avoid redundant memory alloc.