paddle.distribution.StudentT improve input data type and fix returned dimension 易用性提升
#68895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zhwesky2010
approved these changes
Oct 30, 2024
| ) | ||
|
|
||
| if self.df.shape == []: | ||
| self.df = self.df.reshape([1]) |
There was a problem hiding this comment.
@NKNaN 这种0维和1维的问题你再排查下其他distribution api，看看还有没有这种0维改成1维的不合理操作，这个是一个典型的不合理操作：
if x.shape == []:
x= x.reshape([1])
看看其他distribution有没这种问题，目前0维Tensor在paddle内是支持的并全面推广，如果有错误写法，支持不兼容升级过来
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Bug fixes
Description