[PIR] fix pir vector grad #68811
Merged
[PIR] fix pir vector grad #68811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wanghuancoder
requested review from
changeyoung98 and
xiaoguoguo626807
as code owners
|
你的PR提交成功，感谢你对开源项目的贡献! |
From00
approved these changes
Oct 21, 2024
| full_like_op = grad.get_defining_op() | ||
| full_op = full_like_op.operand_source(1).get_defining_op() | ||
| backward_ops_.append(full_like_op) | ||
| backward_ops_.append(full_op) |
There was a problem hiding this comment.
backward_ops 还需要添加split op (values.get_defining_op())
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Execute Infrastructure
PR Types
Bug fixes
Description
append_full_like支持vector of Value
支持builtin.split
Pcard-67164