【Hackathon 7th No.20】为 Paddle 新增 Tensor.set_ -part #68681

NKNaN · 2024-10-14T05:30:57Z

PR Category

User Experience

PR Types

New features

Description

paddle-bot · 2024-10-14T05:31:02Z

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

zxcd · 2024-10-16T06:52:33Z

python/paddle/tensor/creation.py

+            1
+
+    """
+    if in_dynamic_mode():


add data dtype check

added in branch source is not None

zxcd · 2024-10-16T06:57:02Z

paddle/phi/kernels/stride/set_inplace.cc

+
+}  // namespace phi
+
+PD_REGISTER_KERNEL_FOR_ALL_BACKEND_DTYPE(set, STRIDED, phi::SetInplaceKernel) {}


add register for cpu

Does PD_REGISTER_KERNEL_FOR_ALL_BACKEND_DTYPE already register for cpu?

PD_REGISTER_KERNEL is work for cpu

paddle-ci-bot · 2024-10-23T03:05:34Z

Sorry to inform you that 0322026's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

zxcd · 2024-10-28T06:23:51Z

python/paddle/tensor/creation.py

+                raise ValueError(
+                    f"Input (source) should be paddle.Tensor but received {type(source)}"
+                )
+            if source.dtype not in [


suppose to use check_dtype(), also in python code, "bfloat16" should type with "uint16"

zxcd · 2024-10-31T08:06:34Z

paddle/phi/kernels/stride/set_inplace.cc

+                   int64_t,
+                   float,
+                   double,
+                   phi::dtype::complex<float>,


is CPU unspport float16 and bfloat16？

I don't know whether all kind of CPU support float16 and bfloat16 so they are not registered here

I think you can try the same way with paddle/phi/kernels/strided_slice_kernel.cc

OK, float16 and bfloat16 are added.

STRIDED may change to ALL_LAYOUT ？

zxcd

LGTM

jeff41404 · 2024-11-04T07:25:42Z

paddle/phi/kernels/set_inplace.cc

@@ -0,0 +1,77 @@
+// Copyright (c) 2024 PaddlePaddle Authors. All Rights Reserved.


inplace is a concept in the level of ops(in the ops.yaml), representing the space where ops's output can write to the space of input. so in the level of kernel, there is no concept of inplace, because both inplace ops and non-inplace ops use the same computational logic and the same kernel.
so, we suggest filename is set_kernel.cc

jeff41404 · 2024-11-04T07:26:56Z

paddle/phi/kernels/set_inplace_kernel.h

@@ -0,0 +1,30 @@
+// Copyright (c) 2024 PaddlePaddle Authors. All Rights Reserved.


inplace is a concept in the level of ops(in the ops.yaml), representing the space where ops's output can write to the space of input. so in the level of kernel, there is no concept of inplace, because both inplace ops and non-inplace ops use the same computational logic and the same kernel.
so, we suggest filename is set_kernel.h

jeff41404 · 2024-11-04T07:35:31Z

python/paddle/__init__.py

    'diagonal_scatter',
    'combinations',
    'signbit',
+    'set_',


Do we need to support the usage of paddle.set_(x, source, ....)? If it is not recommended for users to use it this way(recommended only x.set_(source, ...) when x is Tensor), there is no need to add it here.

This time only support Tensor.set_ , this line can be deleted.

jeff41404

LGTM

sunzhongkai588

LGTM for docs

luotao1 · 2024-11-06T08:40:35Z

可以提交中文文档啦

paddle-bot bot added the contributor External developers label Oct 14, 2024

luotao1 mentioned this pull request Oct 15, 2024

【Hackathon 7th】开源贡献个人挑战赛 #68244

Closed

luotao1 added PaddlePaddle Hackathon API labels Oct 15, 2024

luotao1 assigned luotao1 and zxcd Oct 15, 2024

zxcd reviewed Oct 16, 2024

View reviewed changes

zxcd reviewed Oct 28, 2024

View reviewed changes

NKNaN added 7 commits October 28, 2024 19:34

add set inplace

9d24782

fix typo

49bb9ca

update test

0556433

update

a0f2027

fix typo

754eddb

fix kernel

10a917b

update check dtype

7f0f15a

NKNaN force-pushed the set_inplace branch from 9eb3a55 to 7f0f15a Compare October 28, 2024 11:34

fix kernel

358c934

zxcd reviewed Oct 31, 2024

View reviewed changes

NKNaN added 2 commits October 31, 2024 18:41

update cpu kernel

3cf1bc0

update kernel

189326b

zxcd approved these changes Nov 4, 2024

View reviewed changes

luotao1 assigned jeff41404 and sunzhongkai588 Nov 4, 2024

jeff41404 reviewed Nov 4, 2024

View reviewed changes

NKNaN added 2 commits November 4, 2024 20:00

update set_

c85cc05

update set_

d959440

zxcd approved these changes Nov 5, 2024

View reviewed changes

jeff41404 approved these changes Nov 5, 2024

View reviewed changes

sunzhongkai588 approved these changes Nov 6, 2024

View reviewed changes

luotao1 merged commit 4ddd410 into PaddlePaddle:develop Nov 6, 2024
28 checks passed

NKNaN mentioned this pull request Nov 7, 2024

【Hackathon 7th No.20】为 Paddle 新增 Tensor.set_ -part PaddlePaddle/docs#6935

Merged


		} // namespace phi

		PD_REGISTER_KERNEL_FOR_ALL_BACKEND_DTYPE(set, STRIDED, phi::SetInplaceKernel) {}

		@@ -0,0 +1,77 @@
		// Copyright (c) 2024 PaddlePaddle Authors. All Rights Reserved.

		@@ -0,0 +1,30 @@
		// Copyright (c) 2024 PaddlePaddle Authors. All Rights Reserved.

【Hackathon 7th No.20】为 Paddle 新增 Tensor.set_ -part #68681

【Hackathon 7th No.20】为 Paddle 新增 Tensor.set_ -part #68681

Uh oh!

Conversation

NKNaN commented Oct 14, 2024

PR Category

PR Types

Description

Uh oh!

paddle-bot bot commented Oct 14, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NKNaN Oct 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

paddle-ci-bot bot commented Oct 23, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zxcd Oct 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zxcd left a comment

Choose a reason for hiding this comment

Uh oh!

jeff41404 Nov 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jeff41404 Nov 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jeff41404 left a comment

Choose a reason for hiding this comment

Uh oh!

sunzhongkai588 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

luotao1 commented Nov 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

NKNaN Oct 23, 2024 •

edited

Loading

zxcd Oct 31, 2024 •

edited

Loading

jeff41404 Nov 4, 2024 •

edited

Loading

jeff41404 Nov 4, 2024 •

edited

Loading