[SOT][3.13] Disable eval frame compilation in python 3.13 #68071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
gouzil
approved these changes
Sep 9, 2024
gouzil
reviewed
Sep 9, 2024
|
|
||
| #include <Python.h> | ||
|
|
||
| #define SOT_NOT_SUPPORTED_VERSION 0x030d0000 |
Member
There was a problem hiding this comment.
- 这个改成
SUPPORTED_VERSION是不是更好一点 - 可以在这补充一个注释：修改
test/dygraph_to_static/test_eval_frame.py文件
Member
Author
There was a problem hiding this comment.
这个改成
SUPPORTED_VERSION是不是更好一点
最开始就这么写的，但是这个版本号 3.13.0 实际上就是没支持的，所以改成了 SOT_NOT_SUPPORTED_VERSION
可以在这补充一个注释：修改
test/dygraph_to_static/test_eval_frame.py文件
喔，下个 PR 改一下
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Execute Infrastructure
PR Types
Devs
Description
eval frame 每个版本都需要单独适配，为免影响 Paddle 整体编译，添加宏
EVAL_FRAME_NOT_SUPPORTED_VERSION，以限制最大支持版本，以免每次版本升级都会编译挂在 eval frame修改后 3.13 下 Paddle 可正常通过编译（M1 macOS 验证，没有在开发机验证），eval frame 会在后续适配 3.13
未来支持 nogil 可以参考 https://py-free-threading.github.io/porting/
Pcard-67164