Skip to content

Conversation

@YuanRisheng
Copy link
Contributor

@YuanRisheng YuanRisheng commented Aug 30, 2024

PR Category

Inference

PR Types

Others

Description

card-71500
本PR做了如下工作:
1,将算子Converter拆解归类到多个代码文件中,方便管理及加速Converter并行开发
2,修复generic_plugin下未正常切换流的问题
3,优化Converter接口设计,改为返回TRT Layer的输出,解决潜在多输出Layer无法与Paddle算子对齐的问题

@paddle-bot
Copy link

paddle-bot bot commented Aug 30, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个是不是应该叫unary.py?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这些文件命名与python对应的api接口是统一的

return relu_layer.get_output(0)


@converter_registry.register("pd_op.softmax", trt_version="8.x")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个属于activation吗?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上,softmax api在paddle里是放在activation里边的

Copy link
Contributor

@vivienfanghuagood vivienfanghuagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YuanRisheng YuanRisheng merged commit eef6557 into PaddlePaddle:develop Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants