[CINN] Implement FusionIters for multi-downstream fusion #67829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
2742195759
approved these changes
Aug 30, 2024
| fused_iters.output_values = downstream_iters.output_values; | ||
| fused_iters.output_iters = downstream_iters.output_iters; | ||
|
|
||
| const auto& upstream_output_value = upstream_iters.output_values[0]; |
There was a problem hiding this comment.
因为是在单下游融合，所以只会有一个输出。多下游融合才会有多个输出。这里可以写一个NOTE
Comment on lines
+79
to
+80
| fused_iters.output_values = downstream_iters.output_values; | ||
| fused_iters.output_iters = downstream_iters.output_iters; |
There was a problem hiding this comment.
这里假设了 ShardableAxes 的处理，已经进行了相同变量的改写。可以写一个NOTE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
Improvements
Description
Pcard-76996
Done in this PR