Skip to content

[XPU] fix memory reserved record when xpu malloc and free #67828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2024
Merged

[XPU] fix memory reserved record when xpu malloc and free #67828

merged 1 commit into from
Aug 30, 2024

Conversation

@lj970926
Copy link
Contributor

@lj970926 lj970926 commented Aug 29, 2024 •
edited
Loading

PR Category

Custom Device

PR Types

Bug fixes

Description

  1. add memory reserve record to XPU when memory alloc/free from/to XPU runtime.

  • before:
    image

  • after:

08ec2a52a275ab999d394d4781f8bc67
  1. add return check to xpu_wait in XPUContext

@paddle-bot
Copy link

paddle-bot bot commented Aug 29, 2024

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

zhangyk0314
zhangyk0314 approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@zhangyk0314 zhangyk0314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cqulilujia
cqulilujia approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@cqulilujia cqulilujia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@houj04 houj04 merged commit 31186ac into PaddlePaddle:develop Aug 30, 2024
@houj04 houj04 added the XPU label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@houj04 houj04 houj04 approved these changes

+2 more reviewers

@cqulilujia cqulilujia cqulilujia approved these changes

@zhangyk0314 zhangyk0314 zhangyk0314 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

XPU

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lj970926 @cqulilujia @houj04 @zhangyk0314