【Infer Symbolic Shape No.176】【BUAA】Add unpool op #67818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
gongshaotian
reviewed
Sep 2, 2024
| std::vector<symbol::DimExpr> output_shape = {x_shape[0], x_shape[1]}; | ||
| for (size_t i = 0; i < ksize.size(); ++i) { | ||
| output_shape.emplace_back(symbol::DimExpr(output_size[i])); | ||
| } |
Hongqing-work
requested changes
Sep 6, 2024
Comment on lines
1603
to
1615
| if (shape_or_data.data().has_value()) { | ||
| output_size_expr = shape_or_data.data().value(); | ||
| } else { | ||
| output_size_expr = shape_or_data.shape(); | ||
| } | ||
| for (const auto &output_size_i : output_size_expr) { | ||
| if (output_size_i.isa<int64_t>()) { | ||
| output_size.emplace_back(output_size_i.dyn_cast<int64_t>()); | ||
| } else { | ||
| PADDLE_THROW(common::errors::InvalidArgument( | ||
| "The type of output_size must be int64, please check.")); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
1、output_size允许是符号表达式，不需要检查output_size_i.isa<int64_t>())
2、output_size_expr = shape_or_data.shape();为错误使用，这里和shape无关
gongshaotian
reviewed
Sep 6, 2024
| if (shape_or_data.data().has_value()) { | ||
| output_size_expr = shape_or_data.data().value(); | ||
| } else { | ||
| output_size_expr = shape_or_data.shape(); |
Contributor
There was a problem hiding this comment.
改为：details::GetOrCreateExprVecFromData(shape_or_data,infer_context);
gongshaotian
reviewed
Sep 6, 2024
Comment on lines
1608
to
1615
| for (const auto &output_size_i : output_size_expr) { | ||
| if (output_size_i.isa<int64_t>()) { | ||
| output_size.emplace_back(output_size_i.dyn_cast<int64_t>()); | ||
| } else { | ||
| PADDLE_THROW(common::errors::InvalidArgument( | ||
| "The type of output_size must be int64, please check.")); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
不需要判断这里可以是符号或者表达式，不需要判断int
gongshaotian
reviewed
Sep 6, 2024
| const std::vector<int> &ksize = details::GetVectorAttr<int>(op, "ksize"); | ||
|
|
||
| const auto &attributes = op->attributes(); | ||
| std::vector<int64_t> output_size; |
Contributor
There was a problem hiding this comment.
这里直接声明成std::vectorsymbol::DimExpr
gongshaotian
reviewed
Sep 6, 2024
| const auto &attributes = op->attributes(); | ||
| std::vector<int64_t> output_size; | ||
| if (attributes.find("output_size") != attributes.end()) { | ||
| output_size = details::GetVectorAttr<int64_t>(op, "output_size"); |
Contributor
There was a problem hiding this comment.
取出来后转成DimExpr吧，这样就统一了，下面不需要output_size_expr了
Contributor
|
pre-commit 一下，codestyle 挂了 |
gongshaotian
approved these changes
Sep 18, 2024
Hongqing-work
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINNPR Types
OthersDescription
Add unpool op.