【auto_parallel】upgrade load_state_dict #67427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zhangbo9674
reviewed
Aug 16, 2024
| import copy | ||
| import os | ||
| from dataclasses import dataclass | ||
| from typing import TYPE_CHECKING |
| ] | ||
|
|
||
| if offload: | ||
| storage_local_tensor = storage_local_tensor.cuda() |
There was a problem hiding this comment.
这里应该要考虑到各个平台的问题，建议通过 _current_expected_place 判断一下
| path, | ||
| process_group=None, | ||
| coordinator_rank=0, | ||
| offload=True, |
| return rank_to_files, missing_keys | ||
|
|
||
|
|
||
| def get_local_load_files_for_multiple_node( |
There was a problem hiding this comment.
这个名字建议换一下，可以用 rank_to_file 表示 rank 可见的文件，rank_to_read_files 表示rank要读的文件
zhangbo9674
approved these changes
Aug 19, 2024
jeff41404
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Auto Parallel
PR Types
Improvements
Description
修改load_state_dict