Fix paddle.linalg.lu when get_infos=True 易用性提升
#67421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zhwesky2010
reviewed
Aug 15, 2024
|
|
||
| auto info_dims = common::slice_ddim(outdims, 0, outrank - 2); | ||
| if (info_dims.size() == 0) { | ||
| info_dims = common::make_ddim({1}); |
Contributor
There was a problem hiding this comment.
这个需要改成 common::make_ddim({}); 吗
Contributor
Author
There was a problem hiding this comment.
outdims 为 {m,n} 时，outrank=2，common::slice_ddim(outdims, 0, 0) 返回的结果应该就是 common::make_ddim({}) 吧
|
|
||
| auto info_dims = common::slice_ddim(outdims, 0, outrank - 2); | ||
| if (info_dims.size() == 0) { | ||
| info_dims = common::make_ddim({1}); |
Contributor
There was a problem hiding this comment.
这个需要改成 common::make_ddim({}); 吗
Contributor
Author
There was a problem hiding this comment.
outdims 为 {m,n} 时，outrank=2，common::slice_ddim(outdims, 0, 0) 返回的结果应该就是 common::make_ddim({}) 吧
Contributor
|
看下 映射文档 + Matcher + 单测 这三方面是否有需要对齐修改的 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Bug fixes
Description
当 paddle.linalg.lu 输入
x形状为 [m, n] 时且get_infos=True，将返回的 info Tensor 从 1-D Tensor 改为 0-D Tensor