[CINN] Fix ReduceTree Fusion #67400
Merged
[CINN] Fix ReduceTree Fusion #67400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
2742195759
reviewed
Aug 14, 2024
| 1, | ||
| ::common::errors::InvalidArgument( | ||
| "Downstream %s must have only one fusion_op.", instr->downstream_)); | ||
| auto upstream_op = std::get<ReduceOp>( |
2742195759
reviewed
Aug 14, 2024
Comment on lines
+124
to
+133
| std::string new_tmp_id() const { | ||
| if (cur_id_ == id_) { | ||
| cur_id_ = id_ + "_tmp_0"; | ||
| } else { | ||
| int ith = std::stoi(cur_id_.substr(cur_id_.size() - 1)); | ||
| cur_id_ = id_ + "_tmp_" + std::to_string(ith + 1); | ||
| } | ||
| return cur_id_; | ||
| } | ||
|
|
There was a problem hiding this comment.
这个不要作为成员函数吧，可以放到 utils 中作为一个工具函数。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
Bug fixes
Description
Pcard-76996