-
Notifications
You must be signed in to change notification settings - Fork 5.9k
[AutoParalle] Support save load for pir dist_program #67045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AutoParalle] Support save load for pir dist_program #67045
Conversation
|
你的PR提交成功,感谢你对开源项目的贡献! |
| using Base::Base; | ||
| using LoD = pir::DenseTensorTypeStorage::LoD; | ||
|
|
||
| static std::string name() { return "t_dist_dense_tensor"; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个可以改成t_dist_dtensor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
| for (auto key : GetOpDistAttr()) { | ||
| if (op.attributes().count(key) > 0) { | ||
| op_json[key] = pir::writeAttr(op.attributes().at(key)); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个地方应该加在op_json[ATTRS] 里,不能给op_json 起新的key
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, tks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Category
Auto Parallel
PR Types
New features
Description
为 PIR dist program 支持 save & load,具体工作包括:
后续扩展分布式属性的 save 及 load 的方法:
Pcard-73145