Skip to content

Conversation

@DongBaiYue
Copy link
Contributor

@DongBaiYue DongBaiYue commented Jul 24, 2024

PR Category

CINN

PR Types

Improvements

Description

在Target的构造函数处检查宏CINN_WITH_*,这样做有以下好处:

  • 尽早报错
  • 集中检查CINN_WITH_*,可以确保使用target.arch.Matcharch对应宏已开启,因此在模式匹配时无需考虑CINN_WITH_*未设置的异常。

Pcard-67164

@paddle-bot
Copy link

paddle-bot bot commented Jul 24, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Jul 24, 2024
@tc20042008 tc20042008 merged commit f64d463 into PaddlePaddle:develop Jul 26, 2024
@DongBaiYue DongBaiYue deleted the check_compile_option branch July 26, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants