Skip to content

Conversation

@AndPuQing
Copy link
Contributor

@AndPuQing AndPuQing commented Jul 23, 2024

PR Category

User Experience

PR Types

Improvements

Description

添加类型提示

相关链接

@paddle-bot
Copy link

paddle-bot bot commented Jul 23, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Jul 23, 2024
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jul 23, 2024
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

输出 type 可以看情况加一加,但不加也没啥大问题,反正这个只是生成脚本不是公开 API

是 PIR 单测修复为牵引梳理代码是吧,顺带加加类型提示这样挺好的~

import pathlib
import sys
from collections import namedtuple
from typing import Dict, List, Tuple
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

使用 PEP 563,并直接使用 builtin 的 dict、list、tuple

Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

其余没啥问题

@AndPuQing
Copy link
Contributor Author

@SigureMo
Copy link
Member

#66384 (files) 这个地方是不是有点问题,好像应该是 int_array_item

目测是的,之后单独提 PR 修一下吧,之后找相关同学 review 下

Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@SigureMo SigureMo merged commit 9ac2d73 into PaddlePaddle:develop Jul 26, 2024
@AndPuQing AndPuQing deleted the typing branch July 26, 2024 03:44
Dale1314 pushed a commit to Dale1314/Paddle that referenced this pull request Jul 28, 2024
lixcli pushed a commit to lixcli/Paddle that referenced this pull request Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers HappyOpenSource 快乐开源活动issue与PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants