[Prim][PIR] Forward decomposite the lerp op #65967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
补充动态shape的单侧 |
zeroRains
commented
Jul 12, 2024
Comment on lines
217
to
224
| if (s != l) { | ||
| if (l == 1) { | ||
| shapes[j] = s; | ||
| } else if (s != 1) { | ||
| } else if (s == 1 || s == -1) { | ||
| shapes[j] = l; | ||
| }else if(l == -1){ | ||
| shapes[j] = s; | ||
| } else { |
There was a problem hiding this comment.
s表示短的dim
l表示长的dim
这里主要讨论从else if开始的情况，在else if一共有9种情况
- s = -1, l = -1， 不存在 （217行的if确定s和l不相等）
- s = -1, l = 1， 不存在（218行的if确定l不为1）
- s = -1, l > 1， shape[j] = l （l大于1，那么s必然为1，这时候可以确定该维度为大于1的结果l，否则运行时也会报错）
- s = 1, l = -1, shape[j] = l （s为1，但是l是-1，l的可以不是1，所以这里设置为-1）
- s = 1, l = 1, 不存在 （217行的if确定s和l不相等）
- s = 1, l > 1, shape[j] = l （s为1，l大于1，所以直接设置成大于1的）
- s > 1, l = -1, shape[j] = s （s大于1，l为-1，所以l必然为1，不然无法广播，运行时会报错）
- s > 1, l = 1, 不存在 （218行的if确定l不为1）
- s > 1, l > 1, 走断言 （已经确定s和l不相等了，并且都是大于1的数，无法广播）
第一个else if 对应情况3，4，6
第二个else if对应情况7
else对应情况9
cyber-pioneer
approved these changes
Jul 16, 2024
| } | ||
| } | ||
| DDim out_dims = common::make_ddim(shapes_out); | ||
| out->set_dims(out_dims); |
lixcli
pushed a commit
to lixcli/Paddle
that referenced
this pull request
Jul 22, 2024
* forward decomposite the lerp op * lerp * fix the bug in the get_output_dims * polish * fix code style * move the modify to infermeta * fix the bug * fix the bug
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Operator Mechanism
PR Types
New features
Description
前向拆解lerp op