[XPU] matmul support new shapes #65963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
lj970926
commented
Jul 11, 2024
| y_dims.to_str(), | ||
| mat_dim_a.trans_, | ||
| mat_dim_b.trans_)); | ||
| if (mat_dim_a.width_ == mat_dim_b.batch_size_ * mat_dim_b.height_) { |
There was a problem hiding this comment.
这里把b矩阵的batch_size和height拼在一起的行为是非法的，b矩阵的height必须严格等于a矩阵的width，具体可以看下面这个numpy的例子（Paddle的matmul接口在设计上与numpy.matmul行为保持一致）：
这个分支唯一合法的情况是batch_size为1时，这种情况下该分支语句的语义和修改后的新写法是一致的
HarperCy
approved these changes
Jul 12, 2024
houj04
approved these changes
Jul 12, 2024
lixcli
pushed a commit
to lixcli/Paddle
that referenced
this pull request
Jul 22, 2024
* support matmul with x_dim >=3, y_dim <= 2 and trans_x = True * add more tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Custom Device
PR Types
New features
Description
fix bugs when
x_dims >= 3,y_dims <= 2, andtrans_x == Truesupport cases where
x_dims <= 2,y_dims >= 3andtrans_y == True.